Fixing sign in via Other needing registration to be enabled#5928
Merged
Fixing sign in via Other needing registration to be enabled#5928
Conversation
- caused by the sign in flow using the registration homeserver validation, fixed by posting the sign in mode event directly
ouchadam
added
the
Z-FTUE
ouchadam
requested review from
a team,
Claire1817 and
mnaturel
and removed request for
a team
ouchadam
added
PR-Small
mnaturel
approved these changes
May 4, 2022
Contributor
mnaturel
left a comment
mnaturel
left a comment
There was a problem hiding this comment.
I have not tested it but code looks good and with the screenshots I see the bug is no more present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes #5874
Will add a test case in a separate PR to help speed this up
Motivation and context
To fix a regression in the onboarding sign in that causes sign in via Other to fail if the homeserver has registration disabled
Screenshots / GIFs
Other
Matrix.org (no changes)
Tests
Tested devices